Welcome!

[seventeen]

I'm building a blog comment class right now and I thought I might try to use variable variable names in the constructor. The database columns match up exactly with the name of the class' data members. Does anyone have any idea why this code isnt working correctly? I'm not getting any error messages. It just doesnt appear to be assigning any values to any of the data members. I think the logic is right, and I'm just overlooking something simple. Maybe someone has better eyes than I do?

Thanks!

Code: Select all

class Comment {
   
   public $id;
   public $post_id;
   public $name;
   public $email;
   public $website;
   public $body;
   public $date;
   public $ip_address;
   
   function __construct($id) {
      
      global $db;

      $resc = $db->query("SELECT * FROM blog_comments WHERE id='$id' LIMIT 1");
      
      while($row = $db->fetch_assoc($resc)) {
         while ($comment = current($row)) {
             $key = key($row);
            $this->$$key = $comment[$key];
            next($row);
         }
      }
   }
}

[falkencreative]

First thing I would do is check this line:

Code: Select all

$this->$$key = $comment[$key];

Looks like you have an extra "$".

[seventeen]

Ahh, ofcourse, this:

Code: Select all

$this->$$key = $comment[$key];

has been changed to this:

Code: Select all

$this->$key = $comment[$key];

However, now I am only getting the first character in each field.

This is what print_r($obj); looks like:

Code: Select all

Comment Object
(
    [id] => 1
    [post_id] => 1
    [name] => J
    [email] => j
    [website] => h
    [body] => b
    [date] => 1
    [ip_address] => :
    [status] => 1
)

Any ideas as to why that might be happening?

This is what the actual query returns:

[seventeen]

Nevermind, figured it out. should have used [] instead of {} in accessing the array element. ofcourse.